Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): add cache to workflows using actions/setup-node #5697

Merged
merged 4 commits into from
Oct 30, 2021
Merged

chore(workflow): add cache to workflows using actions/setup-node #5697

merged 4 commits into from
Oct 30, 2021

Conversation

oscard0m
Copy link
Contributor

Description

Add cache to workflows using actions/setup-node

Context

setup-node GitHub Action just released a new option to add cache to steps using it.

You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/


🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@facebook-github-bot
Copy link
Contributor

Hi @oscard0m!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 96c3c6c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617cf0fd3e50db000765b599

😎 Browse the preview: https://deploy-preview-5697--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 12, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 75
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5697--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 12, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot

This comment has been minimized.

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 13, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oscard0m

I agree we should try using that new cache feature and replace bahmutov/npm-install@v1.

However we are using yarn and we don't want to replace it with npm, so please don't replace yarn install by npm ci

Also why reformating quotes in this PR?

@Josh-Cena
Copy link
Collaborator

The pitfalls of script-generated PRs: you never understand what the workflow is doing😀

LGTM, if all the tests are passing let's merge and see

@Josh-Cena Josh-Cena changed the title ci(workflow): add cache to workflows using actions/setup-node chore(workflow): add cache to workflows using actions/setup-node Oct 30, 2021
@Josh-Cena Josh-Cena merged commit 41346e0 into facebook:main Oct 30, 2021
@oscard0m
Copy link
Contributor Author

The pitfalls of script-generated PRs: you never understand what the workflow is doing😀

LGTM, if all the tests are passing let's merge and see

Thanks for helping me moving this to the last mile

@oscard0m oscard0m deleted the add-cache-to-node-workflows branch October 30, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants