Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include navbar item type in the API table #5821

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Fix #3293. It doesn't hurt to add one extra line anyways, and not indexing code blocks is a correct approach from Algolia IMO.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 29, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 29, 2021
@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ [V2]

🔨 Explore the source changes: e5e4e42

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617bc6348cfc750007ad30a3

😎 Browse the preview: https://deploy-preview-5821--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5821--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -12 B (0%)

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 425 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB 0 B
website/build/blog/index.html 39 kB 0 B
website/build/docs/index.html 46.1 kB -6 B (0%)
website/build/docs/installation/index.html 53.6 kB -6 B (0%)
website/build/index.html 31.6 kB 0 B
website/build/tests/docs/index.html 27.3 kB 0 B
website/build/tests/docs/standalone/index.html 23.8 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit 7468136 into main Oct 29, 2021
@Josh-Cena Josh-Cena deleted the jc/document-navbar-item-type branch October 29, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search does not find "docsVersionDropdown"
2 participants