Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): remove v2 prefix from titles #5833

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Now that all the stuff is v2, we no longer need the v2 prefix in every test. This makes the test reports more concise.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 30, 2021
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 30, 2021
@netlify
Copy link

netlify bot commented Oct 30, 2021

✔️ [V2]

🔨 Explore the source changes: 21ec845

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617cf5c253dadb000838a264

😎 Browse the preview: https://deploy-preview-5833--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5833--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -12 B (0%)

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/assets/js/main.********.js 425 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB 0 B
website/build/blog/index.html 39 kB 0 B
website/build/docs/index.html 46.1 kB -6 B (0%)
website/build/docs/installation/index.html 53.6 kB -6 B (0%)
website/build/index.html 31.6 kB 0 B
website/build/tests/docs/index.html 27.3 kB 0 B
website/build/tests/docs/standalone/index.html 23.8 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena changed the title chore(workflow): remove v2 prefix chore(workflow): remove v2 prefix from titles Oct 30, 2021
@Josh-Cena Josh-Cena merged commit 66771bd into main Oct 30, 2021
@Josh-Cena Josh-Cena deleted the jc/cleanup-workflow branch October 30, 2021 07:48
HemantSachdeva added a commit to HemantSachdeva/docusaurus that referenced this pull request Nov 4, 2021
 * Commit 66771bd renames the file v2-tests.yml to tests.yml
   in PR facebook#5833 which broke the github actions test icon.

Signed-off-by: Hemant Sachdeva <[email protected]>
HemantSachdeva added a commit to HemantSachdeva/docusaurus that referenced this pull request Nov 4, 2021
 * Commit 66771bd renames the file v2-tests.yml to tests.yml
   in PR facebook#5833 which broke the github actions test icon and link to workflow.

Signed-off-by: Hemant Sachdeva <[email protected]>
HemantSachdeva added a commit to HemantSachdeva/docusaurus that referenced this pull request Nov 4, 2021
 * Commit 66771bd renames the file v2-tests.yml to tests.yml
   in PR facebook#5833 which broke the github actions test icon and link to the workflow.

Signed-off-by: Hemant Sachdeva <[email protected]>
Josh-Cena pushed a commit that referenced this pull request Nov 4, 2021
* Commit 66771bd renames the file v2-tests.yml to tests.yml
   in PR #5833 which broke the github actions test icon and link to the workflow.

Signed-off-by: Hemant Sachdeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants