-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workflow): remove v2 prefix from titles #5833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
label
Oct 30, 2021
✔️ [V2] 🔨 Explore the source changes: 21ec845 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617cf5c253dadb000838a264 😎 Browse the preview: https://deploy-preview-5833--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5833--docusaurus-2.netlify.app/ |
Size Change: -12 B (0%) Total Size: 847 kB ℹ️ View Unchanged
|
Josh-Cena
changed the title
chore(workflow): remove v2 prefix
chore(workflow): remove v2 prefix from titles
Oct 30, 2021
HemantSachdeva
added a commit
to HemantSachdeva/docusaurus
that referenced
this pull request
Nov 4, 2021
* Commit 66771bd renames the file v2-tests.yml to tests.yml in PR facebook#5833 which broke the github actions test icon. Signed-off-by: Hemant Sachdeva <[email protected]>
HemantSachdeva
added a commit
to HemantSachdeva/docusaurus
that referenced
this pull request
Nov 4, 2021
* Commit 66771bd renames the file v2-tests.yml to tests.yml in PR facebook#5833 which broke the github actions test icon and link to workflow. Signed-off-by: Hemant Sachdeva <[email protected]>
HemantSachdeva
added a commit
to HemantSachdeva/docusaurus
that referenced
this pull request
Nov 4, 2021
* Commit 66771bd renames the file v2-tests.yml to tests.yml in PR facebook#5833 which broke the github actions test icon and link to the workflow. Signed-off-by: Hemant Sachdeva <[email protected]>
Josh-Cena
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Commit 66771bd renames the file v2-tests.yml to tests.yml in PR #5833 which broke the github actions test icon and link to the workflow. Signed-off-by: Hemant Sachdeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that all the stuff is v2, we no longer need the v2 prefix in every test. This makes the test reports more concise.
Have you read the Contributing Guidelines on pull requests?
Yes