-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-blog): Fix blog feeds not generated #5835
Conversation
Size Change: 0 B Total Size: 847 kB ℹ️ View Unchanged
|
✔️ [V2] 🔨 Explore the source changes: 68c4e07 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617d18ffdc50bc000738e1e6 😎 Browse the preview: https://deploy-preview-5835--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5835--docusaurus-2.netlify.app/ |
Do you mean build simple site as Jest test? We had something like that in v1. https://github.com/facebook/docusaurus/blob/docusaurus-v1/packages/docusaurus-1.x/lib/__tests__/build-files.test.js |
Yes, this kind of test can probably be done after the end of the e2e workflow, not sure where to put the files though because it shouldn't execute by default when running |
Prettier has a separate repo with fixtures for testing new releases. Maybe we can make a mock site repo as well🧐 |
Motivation
Blog feeds are not generated anymore due to a typo in a recent refactor 😓
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
no :'( we should probably add some tests though