-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: replace all "Metadatas" with "Metadata" #5871
Conversation
The plural form of Metadata is Metadata itself and not Metadatas.
Hi @swalahamani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✔️ [V2] 🔨 Explore the source changes: 27c336f 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6187a3d621201200070a4a0b 😎 Browse the preview: https://deploy-preview-5871--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5871--docusaurus-2.netlify.app/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This comment has been minimized.
This comment has been minimized.
I don't really know... I also have some objection to "metadatas" but we use it here and there. I'm going to use this chance to run a global search & replace @slorber What do you think? I think there are only two worlds: (a) we close this PR and do nothing and pretend we are grammar masters and (b) we fix all "metadatas" including the |
It's my fault, used to think metadatas was correct 😅 I'm ok to change it everywhere, including a breaking change in theme API considering we'd rather do that before 2.0 |
Actually, I did a random chat with someone else and they said
But anyways, fixing it seems more sensible |
This comment has been minimized.
This comment has been minimized.
🤪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 👍
Co-authored-by: Josh-Cena <[email protected]>
Replace the "Metadatas" keyword with "Metadata" facebook/docusaurus#5871 Moved gtag options out of themeConfig facebook/docusaurus#5832
Breaking changes
We replaced all API containing
metadatas
withmetadata
. This includes but is not limited to:themeConfig.metadatas
Layout.Props.searchMetadatas
@theme/SearchMetadatas
If you use any of these APIs, you need to update accordingly.
Why? Because
metadatas
is grammatically incorrect. We are not going to pretend like we are grammar masters who made this API with a surprising purpose—we are just wrong, and now we fix it.Motivation
The plural form of Metadata is Metadata itself and not Metadatas.
Please refer: Wordhippo
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
N/A as this is just a spelling correction.
Related PRs
N/A