fix(content-blog): make post ID unique #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
pr: breaking change
Josh-Cena
commented
Dec 7, 2021
| @@ -13,14 +13,14 @@ exports[`blogFeed atom shows feed item for each post 1`] = ` | |||
| <rights>Copyright</rights> | |||
| <entry> | |||
| <title type=\\"html\\"><![CDATA[MDX Blog Sample with require calls]]></title> | |||
| <id>MDX Blog Sample with require calls</id> | |||
| <id>/mdx-require-blog-post</id> | |||
There was a problem hiding this comment.
Should you be wondering: the id field doesn't really matter for the feeds. The example of the library itself uses post.url as the ID.
|
✔️ [V2] 🔨 Explore the source changes: 209fd5f 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61af48c1aa156b0008053238 😎 Browse the preview: https://deploy-preview-6061--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6061--docusaurus-2.netlify.app/ |
|
Size Change: +1.22 kB (0%) Total Size: 657 kB
ℹ️ View Unchanged
|
Josh-Cena
added
status: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The blog posts' ID may have changed. Previously, they represented neither the slug nor the title: it was a weird mix of the two, which makes it pretty useless for rendering. Moreover, we discovered that this ID generation is not guaranteed to be unique either. Now, we have normalized all IDs into the posts' slugs. If you relied on the whacky IDs before in your swizzled component, consider using either
metadata.titleorsluginstead.Motivation
Fix #6059
Test plans
Added two dogfooding posts