-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove deprecated docs homePageId option #6065
Conversation
✔️ [V2] 🔨 Explore the source changes: 2f19533 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61af73f6e7eaf50007afe5b6 😎 Browse the preview: https://deploy-preview-6065--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6065--docusaurus-2.netlify.app/ |
I've thought about it, but |
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
Just fixed it, users will need to set the root doc item manually. |
LGTM thanks 👍 |
Breaking changes
The
homePageId
has been marked as deprecated for a long time. Users usinghomePageId
should consider settingslug: /
in the front matter of their doc file instead.Motivation
The
homePageId
has been declared deprecated for over a year now, it's probably time to remove it.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview/tests
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)