Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor styling/theming docs #6129

Merged
merged 2 commits into from
Dec 19, 2021
Merged

docs: refactor styling/theming docs #6129

merged 2 commits into from
Dec 19, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

These docs have constantly confused me and other people. Time to make it more coherent as we try to also improve theming experience.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 19, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 19, 2021
@netlify
Copy link

netlify bot commented Dec 19, 2021

✔️ [V2]

🔨 Explore the source changes: 5ffedac

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61be995b08ea350007dcac83

😎 Browse the preview: https://deploy-preview-6129--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 19, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6129--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Dec 19, 2021

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 37.8 kB
website/build/assets/css/styles.********.css 101 kB
website/build/assets/js/main.********.js 484 kB
website/build/index.html 29.6 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit ac7c767 into main Dec 19, 2021
@Josh-Cena Josh-Cena deleted the jc/theme-doc branch December 19, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants