-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): async docusaurus.config.js creator function #6165
Conversation
✔️ [V2] 🔨 Explore the source changes: 0b63194 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c33f3797ffc0000734edb2 😎 Browse the preview: https://deploy-preview-6165--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6165--docusaurus-2.netlify.app/ |
This actually means we can support ESM remark plugins, because they can now be |
Size Change: 0 B Total Size: 662 kB ℹ️ View Unchanged
|
Maybe we should dogfood this first and ensure it works before documenting it? I'm not sure to see how it would actually work considering we are still using Remark 12 and most ES plugins are for Remark 13? It is retro compatible enough so that Remark 13 plugins can work with our current setup? |
Hmmm, that part I don't know😄 We can still test |
Motivation
Fixes #3791
We should be able to use async code to create the config.
Later: we'll try to also support ESM config + top-level await
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
tests + dogfood