Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not coerce webpack warning to string #6378

Merged
merged 1 commit into from
Jan 16, 2022
Merged

fix(core): do not coerce webpack warning to string #6378

merged 1 commit into from
Jan 16, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Currently it logs [object Object]

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 16, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 16, 2022
@PatelN123
Copy link
Contributor

image

Thanks for this! 😄

@netlify
Copy link

netlify bot commented Jan 16, 2022

✔️ [V2]

🔨 Explore the source changes: 2d54fa3

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61e40426b7864d00076ce05c

😎 Browse the preview: https://deploy-preview-6378--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6378--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit ad16f4f into main Jan 16, 2022
@Josh-Cena Josh-Cena deleted the jc/warn branch January 16, 2022 11:47
@github-actions
Copy link

Size Change: 0 B

Total Size: 678 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 42.9 kB
website/build/assets/css/styles.********.css 103 kB
website/build/assets/js/main.********.js 503 kB
website/build/index.html 29.6 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants