Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(init): promote good practices; use site alias #6481

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

This makes the init template more in line with the best practices we outlined.

  1. Images are required instead of using useBaseUrl
  2. Styles are collocated with their code files in separate folders
  3. Components are imported with @site alias rather than relative paths

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Build

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 27, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 27, 2022
@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ [V2]

🔨 Explore the source changes: 121911a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f240b54991de0007e5f2ea

😎 Browse the preview: https://deploy-preview-6481--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6481--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 721 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 46.7 kB
website/build/assets/css/styles.********.css 104 kB
website/build/assets/js/main.********.js 540 kB
website/build/index.html 29.8 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jan 27, 2022

LGTM 👍

@slorber slorber merged commit 4c22316 into main Jan 27, 2022
@slorber slorber deleted the jc/use-alias branch January 27, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants