Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow passing a list of file names to write-heading-ids #6500

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Bash automatically expands globs, but our write-heading-ids files option is not variadic.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Wrote heading IDs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2022
@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ [V2]

🔨 Explore the source changes: 40ea4ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f4bdd903b19800074ec570

😎 Browse the preview: https://deploy-preview-6500--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6500--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 755 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 47 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 573 kB
website/build/index.html 30.1 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit c1e3801 into main Jan 29, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-write-heading-id branch January 29, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants