Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): apply width/height for footer logos without href #6508

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented Jan 29, 2022

Motivation

Fixes #6503

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I manually tested the Footer component using my local packages to ensure the height and width attributes were set on the logo image element with the following configuration:

footer: {
  logo: {
    alt: "Logo",
    src: "img/logo.png",
    height: 50,
    width: 50,
  }
}

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2022
@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 29, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 61a7e37

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f5554b6ca34500074a1f0b

😎 Browse the preview: https://deploy-preview-6508--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6508--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title fix(theme-classic): footer logo height and width props not being set fix(theme-classic): apply width/height for footer logos without href Jan 29, 2022
@Josh-Cena Josh-Cena merged commit dda92eb into facebook:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer logo height and width not being set when href not present
3 participants