Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): add docSidebar as allowed item in dropdown #6599

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

homotechsual
Copy link
Contributor

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 7af91c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fc81a17ba1ea00080304d6

😎 Browse the preview: https://deploy-preview-6599--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6599--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Feb 4, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit d6bdf7e into facebook:main Feb 4, 2022
@homotechsual
Copy link
Contributor Author

Sorry about the comment changes - will double check why VSCode changed those.

@Josh-Cena
Copy link
Collaborator

I've never heard of vscode being able to wrap comments, but if you have some extension, make sure it wraps at 80 cols

@homotechsual homotechsual deleted the themeconfigvalidation branch February 4, 2022 01:56
PdoubleU added a commit to TheWidlarzGroup/react-native-notificated that referenced this pull request May 26, 2022
1. Upgrade docsaurus from 2.0.0-beta.14 to 2.0.0-beta.16:
       - new version fixes a bug regarding to items type (docsaurus.config.js), here more comments on that:
       facebook/docusaurus#6599
2. Add sidebars for: intro and api
      - move intro and associated folders into 'intro'
      - add 'api' folder and types and api files inside it
3. Set up sidebars for intro (as Documentation) and api (as API Reference)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants