Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-docs): allow omitting enclosing array consistently for category shorthand #6602

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Omitting the enclosing array is allowed for the top-level, but not for the children. This PR makes the behavior aligned and eliminates the confusion from some users.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added two unit tests

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 4, 2022
@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ [V2]

🔨 Explore the source changes: 0840627

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fc955666cae1000823aeaf

😎 Browse the preview: https://deploy-preview-6602--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 66
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6602--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Size Change: +26 B (0%)

Total Size: 772 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 47.2 kB 0 B
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/assets/js/main.********.js 582 kB +26 B (0%)
website/build/index.html 36.7 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ [V2]

🔨 Explore the source changes: dfe5116

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fc98aa7673630008db1c02

😎 Browse the preview: https://deploy-preview-6602--docusaurus-2.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants