fix(cli): log error itself on unhandled rejection #6607
Conversation
|
✔️ [V2] 🔨 Explore the source changes: 4521675 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fd44e195d2cb00072f37fc 😎 Browse the preview: https://deploy-preview-6607--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6607--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 771 kB ℹ️ View Unchanged
|
| @@ -254,6 +254,6 @@ async function run() { | |||
| run(); | |||
|
|
|||
| process.on('unhandledRejection', (err) => { | |||
| logger.error(err.stack); | |||
There was a problem hiding this comment.
we have error.stack logged in multiple other places of the codebase, should we clean those up too?
Does it work correctly with toString/string interpolation logs?
Not sure why exactly, I think Node.js didn't log properly in older versions? 🤷♂️
There was a problem hiding this comment.
I don't know why either. Errors can both be stringified and logged very nicely. And yeah, I'll probably clean up the rest later
Motivation
See #6606. Since this rarely happens, it doens't hurt to log more. Errors themselves can be well-formatted in the console anyways.
Have you read the Contributing Guidelines on pull requests?
Yes