Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-docs): add custom props front matter #6619

Merged
merged 5 commits into from
Feb 9, 2022
Merged

feat(content-docs): add custom props front matter #6619

merged 5 commits into from
Feb 9, 2022

Conversation

TheCatLady
Copy link
Contributor

@TheCatLady TheCatLady commented Feb 6, 2022

Motivation

Close #6590

Have you read the Contributing Guidelines on pull requests?

Yes 😸 But please let me know if I did anything incorrectly!

Test Plan

Added:

  • Unit test
  • Dogfooding example

@netlify
Copy link

netlify bot commented Feb 6, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 23237bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6203be271036770008a92754

😎 Browse the preview: https://deploy-preview-6619--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6619--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Josh-Cena
Copy link
Collaborator

Needing some documentation. Just a mention in the autogenerated sidebars section is fine

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Feb 7, 2022
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@Josh-Cena want to do more changes?

@Josh-Cena
Copy link
Collaborator

I'm good! If we don't merge this tonight I'll do last checks tomorrow

@slorber slorber merged commit 665d164 into facebook:main Feb 9, 2022
@TheCatLady TheCatLady deleted the dh/custom-props branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow access to frontmatter in child pages from a category index page.
4 participants