Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): improve sidebar shorthand normalization error message #6745

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

The normalization sometimes throws "item.items.flatMap is not a function" which is totally cryptic. This hopefully makes it better.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added a few common cases

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 23, 2022
@netlify
Copy link

netlify bot commented Feb 23, 2022

✔️ [V2]

🔨 Explore the source changes: dbb3997

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621620647fecf0000905be5f

😎 Browse the preview: https://deploy-preview-6745--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6745--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Size Change: 0 B

Total Size: 781 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 48 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 590 kB
website/build/index.html 37.6 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 23, 2022

Thanks 👍

@slorber slorber merged commit 2d93750 into main Feb 23, 2022
@slorber slorber deleted the jc/improve-sidebar-error branch February 23, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants