Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify error handling behavior #6755

Merged
merged 11 commits into from
Feb 25, 2022
Merged

refactor: unify error handling behavior #6755

merged 11 commits into from
Feb 25, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Always provide the stack and do not assume the error is Error

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 25, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 25, 2022
@netlify
Copy link

netlify bot commented Feb 25, 2022

✔️ [V2]

🔨 Explore the source changes: 3850eaf

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62187d19047e3600077b10b2

😎 Browse the preview: https://deploy-preview-6755--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 25, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6755--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 25, 2022

Size Change: 0 B

Total Size: 782 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 48 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 591 kB
website/build/index.html 37.6 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit f903422 into main Feb 25, 2022
@Josh-Cena Josh-Cena deleted the jc/refactor branch February 25, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants