fix(theme-common): isSamePath should be case-insensitive #6758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes the user has a filename like
Capitalized.md
leading to a slug with some uppercase chars such as/docs/Capitalized
But this URL is often normalized to
/docs/capitalized
by CDN/hosts and then when we try to match the 2 paths we consider they are different.This leads to subtle UX issues such as:
The helper function
isSamePath
should be case-insensitive to fix it.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests + dogfood