Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add TypeScript template to E2E test matrix #6768

Merged
merged 6 commits into from
Feb 27, 2022
Merged

test: add TypeScript template to E2E test matrix #6768

merged 6 commits into from
Feb 27, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

After #6762, I think it's key that we also make sure the TypeScript template runs well. This could also help catch typing errors.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

New test

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 26, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 26, 2022
@netlify
Copy link

netlify bot commented Feb 26, 2022

✔️ [V2]

🔨 Explore the source changes: 7c8fef6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6219bd8684338f00080b5a90

😎 Browse the preview: https://deploy-preview-6768--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 26, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6768--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 26, 2022

Size Change: 0 B

Total Size: 789 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.7 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 596 kB
website/build/index.html 37.6 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 26, 2022

✔️ [V2]

🔨 Explore the source changes: 5f53639

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621acd2c2998bc0007ba3121

😎 Browse the preview: https://deploy-preview-6768--docusaurus-2.netlify.app

@Josh-Cena Josh-Cena merged commit bafa471 into main Feb 27, 2022
@Josh-Cena Josh-Cena deleted the jc/ts-test branch February 27, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants