Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx-loader): suppress image reading warning in Yarn PnP; log warning instead of error #6779

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Feb 27, 2022

Motivation

Fix #6774. Yarn PnP patches FS and generates a virtual file handle, but they forgot to map it back to the actual fd when calling stat(). This makes image-size unhappy. More information in yarnpkg/berry#3889 (comment).

In addition, I've downgraded the error to a warning, hoping it would be less intimidating for users.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Feb 27, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 27, 2022
@netlify
Copy link

netlify bot commented Feb 27, 2022

✔️ [V2]

🔨 Explore the source changes: 97aecbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621b6c19fc5a1f0008ebc9f8

😎 Browse the preview: https://deploy-preview-6779--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6779--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 789 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.7 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 596 kB
website/build/index.html 37.6 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 9d7ed31 into main Feb 28, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-warning branch February 28, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default images can't be rendered: "The "path" argument must be of type string. Received type number (58)"
2 participants