Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove hash/query when filtering existing files for broken link check #6812

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 2, 2022

Motivation

Fix #6810

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added a test

@Josh-Cena Josh-Cena added CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release. labels Mar 2, 2022
@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ [V2]

🔨 Explore the source changes: 6aae1dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621ef2ad1f3bfc00075585a2

😎 Browse the preview: https://deploy-preview-6812--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6812--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Size Change: 0 B

Total Size: 789 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.7 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 596 kB
website/build/index.html 37.6 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ [V2]

🔨 Explore the source changes: 8904ea6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621ef34c1ac53500072b1ce6

😎 Browse the preview: https://deploy-preview-6812--docusaurus-2.netlify.app

@Josh-Cena Josh-Cena merged commit 954e4d4 into main Mar 2, 2022
@Josh-Cena Josh-Cena deleted the jc/no-hash-link-check branch March 2, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML links broken in markdown when they include URL fragment #
1 participant