Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix swizzle legend typo #6854

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

DigiPie
Copy link
Contributor

@DigiPie DigiPie commented Mar 6, 2022

Motivation

Fix swizzle status description typo.

Have you read the Contributing Guidelines on pull requests?

Yep

Test Plan

yarn test packages/docusaurus/src/commands/swizzle

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2022
@Josh-Cena
Copy link
Collaborator

Thanks! Most of the credit goes to @slorber — he wrote most of this stuff, I just did the initial work 😄

@netlify
Copy link

netlify bot commented Mar 6, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: b7d157e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622421f2317aa400072863be

😎 Browse the preview: https://deploy-preview-6854--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 52
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6854--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 6, 2022
@netlify
Copy link

netlify bot commented Mar 6, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 7f84c1b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622422498648a200077e7b8e

😎 Browse the preview: https://deploy-preview-6854--docusaurus-2.netlify.app

@Josh-Cena Josh-Cena merged commit 9f925a4 into facebook:main Mar 6, 2022
@DigiPie
Copy link
Contributor Author

DigiPie commented Mar 6, 2022

Thanks! Most of the credit goes to @slorber — he wrote most of this stuff, I just did the initial work 😄

I see, thanks @slorber 😃

@DigiPie DigiPie deleted the evan/new-swizzle-typo-fix branch March 6, 2022 04:08
@slorber
Copy link
Collaborator

slorber commented Mar 9, 2022

np :) thanks for fixing my typos :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants