Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): improve error message when a page has no default-export #6941

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Close #6940

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 19, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 19, 2022
@netlify
Copy link

netlify bot commented Mar 19, 2022

✅ [V2]

🔨 Explore the source changes: 3e14f2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6235302e40b803000824c3c8

😎 Browse the preview: https://deploy-preview-6941--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 48
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6941--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 53f152c into main Mar 19, 2022
@Josh-Cena Josh-Cena deleted the jc/improve-error branch March 19, 2022 01:30
@github-actions
Copy link

Size Change: +132 B (0%)

Total Size: 804 kB

Filename Size Change
website/build/assets/js/main.********.js 611 kB +132 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use tsx files in /pages
2 participants