Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme-classic): remove span wrappers from layout links #6985

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 24, 2022

Motivation

Applying changes from Infima - facebookincubator/infima#214

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview (/tests pages)

Related PRs

#6846

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

[V2]

Name Link
🔨 Latest commit 84f65d3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623c87762b1d96000856fac6
😎 Deploy Preview https://deploy-preview-6985--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6985--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -565 B (0%)

Total Size: 805 kB

Filename Size Change
website/build/assets/js/main.********.js 612 kB -58 B (0%)
website/build/index.html 38.3 kB -507 B (-1%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Mar 24, 2022

thanks 👍

@slorber slorber merged commit 4c0914c into main Mar 24, 2022
@slorber slorber deleted the lex111/spans-bye-bye branch March 24, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants