Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix unclosed admonition code block #8363

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

Zwyx
Copy link
Contributor

@Zwyx Zwyx commented Nov 22, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Two code blocks were merged together because of errors with the three back ticks.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Zwyx Zwyx requested a review from slorber as a code owner November 22, 2022 07:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 22, 2022
@netlify
Copy link

netlify bot commented Nov 22, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit badc0de
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/637cca3fb0e00f0009d08d40
😎 Deploy Preview https://deploy-preview-8363--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Zwyx Zwyx changed the title Fix code blocks docs: fix code blocks Nov 22, 2022
Two code blocks were merged together because of errors with the three back ticks
@slorber
Copy link
Collaborator

slorber commented Nov 23, 2022

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 23, 2022
@slorber slorber changed the title docs: fix code blocks docs: fix unclosed admonition code block Nov 23, 2022
@slorber slorber merged commit 412d2db into facebook:main Nov 23, 2022
@Zwyx Zwyx deleted the patch-2 branch November 24, 2022 03:20
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants