Updating step 2 to be more intuitive: "Avoiding use of the word github" #900
Conversation
Use of word Github is very confusing. When starting, most of devs wont have an existing github repo. And normally not everyone will be using Github. Since devs will be following this step by step: we need to stress on telling them to create a new or use existing local project folder which may or may not be a github repo.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
1 similar comment
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit e8ee056 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@apuravchauhan Thank you for your contribution. I made some modifications and updates. If you feel I enhanced what you were trying to say, then we can merge this now. If you do not like, let me know.
|
@JoelMarcey Perfect. Thanks for reviewing |
|
Also fixes #893 |
Use of word Github is very confusing. When starting, most of devs wont have an existing github repo. And normally not everyone will be using Github. Since devs will be following this step by step: we need to stress on telling them to create a new or use existing local project folder which may or may not be a github repo.
Motivation
Installation is foremost step to begin with this framework and this PR makes its more intuitive.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No code changed. Only textual change for now
Related PRs
This PR updates the doc