fix(theme): support details/summary in CommonMark + add md dogfood test cases #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: documentation
7 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
slorber
changed the title
slorber
removed
the
pr: documentation
slorber
changed the title
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having similar tests for md/mdx modes ensure we offer a consistent experience to our users.
Currently, those tests show it's not the case, see problems reported here: #9092
Also add better tests for html comments support, cf edge case bug reported here: #9084
This PR is also a mini fix adding support for summary/details in CommonMark mode, see #9092 (comment)
Test Plan
preview
Test links
https://deploy-preview-9093--docusaurus-2.netlify.app/tests/pages/markdown-tests-md
https://deploy-preview-9093--docusaurus-2.netlify.app/tests/pages/markdown-tests-mdx
Related issues/PRs