Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: only install Chromium for Playwright Argos tests #9264

Merged
merged 1 commit into from
Aug 31, 2023
Merged

ci: only install Chromium for Playwright Argos tests #9264

merged 1 commit into from
Aug 31, 2023

Conversation

mxschmitt
Copy link
Contributor

This should give you a speed boost of 30-40 seconds.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 26, 2023
@netlify
Copy link

netlify bot commented Aug 26, 2023

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 90d358b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64ea24cf06ca430008f97f5e
😎 Deploy Preview https://deploy-preview-9264--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 71 🟢 98 🟢 92 🟢 100 🟠 89 Report

JusminCode
JusminCode reviewed Aug 27, 2023
View reviewed changes
Copy link

@JusminCode JusminCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this is very cool for me.

@slorber
Copy link
Collaborator

slorber commented Aug 31, 2023

Thanks for that 🙏 didn't know that option

@slorber slorber added Argos Add this label to run UI visual regression tests. See argos.yml GH action. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Aug 31, 2023
@slorber slorber changed the title devops: only install Chromium for argos tests ci: only install Chromium for Playwright Argos tests Aug 31, 2023
@argos-ci
Copy link

argos-ci bot commented Aug 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Aug 31, 2023, 10:33 AM

@slorber slorber merged commit bc150d2 into facebook:main Aug 31, 2023
8 checks passed
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JusminCode JusminCode JusminCode left review comments

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxschmitt @slorber @JusminCode @facebook-github-bot