Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): remove duplicated function #9949

Closed
wants to merge 6 commits into from
Closed

Conversation

OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Mar 13, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Avoid duplication of code

Test Plan

Deploy and jest ?

Test links

Deploy preview: https://deploy-preview-9949--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

[V2]

Name Link
🔨 Latest commit 32fa7e0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65f45321d3e4d200073bc786
😎 Deploy Preview https://deploy-preview-9949--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 13, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 66 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 71 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented Mar 13, 2024

Size Change: +301 B (0%)

Total Size: 993 kB

Filename Size Change
website/build/assets/css/styles.********.css 114 kB -64 B (0%)
website/build/assets/js/main.********.js 765 kB +365 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/index.html 37.9 kB

compressed-size-action

@OzakIOne OzakIOne marked this pull request as ready for review March 15, 2024 14:08
@OzakIOne
Copy link
Contributor Author

OzakIOne commented Mar 15, 2024

Hmm need to investigate on this git merge main problem :(

Will be doing a new pr from main, won't have those merged commits problem 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants