Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libcurl in getdeps #27

Closed
wants to merge 2 commits into from

Commits on Mar 11, 2022

  1. getdeps optionally can get hg info from env var

    Summary:
    Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly.
    
    When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`.
    
    This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available.
    
    Differential Revision: D34732506
    
    fbshipit-source-id: 2b0fc664cb4afe1315ff62d35c617ae1e9a126e3
    dgrnbrg-meta authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    108a7cd View commit details
    Browse the repository at this point in the history
  2. use libcurl in getdeps

    Summary:
    When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/).
    
    This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment.
    
    Reviewed By: mackorone
    
    Differential Revision: D34696330
    
    fbshipit-source-id: 0dcc935ae7273e1d56ff413d45c738b693ac4fc5
    dgrnbrg-meta authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    355eed6 View commit details
    Browse the repository at this point in the history