Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument to pass extra arguments to boost b2 build tool (#115) #28

Closed
wants to merge 3 commits into from
Closed

Add argument to pass extra arguments to boost b2 build tool (#115) #28

wants to merge 3 commits into from

Commits on Mar 11, 2022

  1. getdeps optionally can get hg info from env var 

    Summary:
Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly.

When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`.

This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available.

Differential Revision: D34732506

fbshipit-source-id: 8cd08d5c3f46abae868168682cf6e0a9017317bc
    @dgrnbrg-meta @facebook-github-bot
    dgrnbrg-meta authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    bab90f5 View commit details
    Browse the repository at this point in the history

  2. use libcurl in getdeps 

    Summary:
When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/).

This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment.

Differential Revision: D34696330

fbshipit-source-id: 5bdd78bb25a63540de6bda380ca3beb472c34c4d
    @dgrnbrg-meta @facebook-github-bot
    dgrnbrg-meta authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    af73eb4 View commit details
    Browse the repository at this point in the history

  3. Add argument to pass extra arguments to boost b2 build tool (#115) 

    Summary:
X-link: facebook/fboss#115

X-link: facebook/folly#1736

X-link: facebook/proxygen#403

X-link: facebook/fbthrift#488

This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects.

Reviewed By: mackorone

Differential Revision: D34796774

fbshipit-source-id: 9747fef6310f34b9d33f57b3e552a1fb9c886d6e
    @dgrnbrg-meta @facebook-github-bot
    dgrnbrg-meta authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    e736ba1 View commit details
    Browse the repository at this point in the history