[fbjs][fbjs-scripts] Upgrade core-js version #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I force pushed to try and get TravisCI to run. It ran, and almost everything passed but the Node10 Lint job failed to download Node.JS, some how. Everything else passed! |
zpao
approved these changes
Apr 6, 2020
Closed
|
@zpao while this has been merged, it's still The warning will continue as a result. |
facebook-github-bot
pushed a commit
to facebook/relay
that referenced
this pull request
Sep 14, 2020
Summary: Every time I run `yarn upgrade` on a personal project it spits out a warning: ``` warning react-relay > fbjs > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3. ``` [New versions of fbjs and fbjs-scripts](facebook/fbjs@1f14496) were released back in July that included a PR to [upgrade `core-js` to version 3](facebook/fbjs#370). This bumps the `fbjs` and `fbjs-scripts` versions to 2.0.0 for relay and all of its packages, which eliminates `core-js@<3` completely! Pull Request resolved: #3184 Reviewed By: kassens Differential Revision: D23667268 Pulled By: bigfootjon fbshipit-source-id: f7ee028d6555b43af63b2e913e5db5ba78394a06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I use yarn I get a warning about how core-js < 3 is not supported for
relayandfluxthroughfbjs. This migratescore-jsto version 3 forfbjsandfbjs-scripts.@zpao please, you're my only hope