Skip to content

Commit

Permalink
Fix D65159011 regression
Browse files Browse the repository at this point in the history
Summary:
D65159011 added an empty folly::IPAddress: https://fburl.com/code/qgcdf74t
This fails on in toSaiIpAddress as its folly::address_unreachable.

Fix it by returning some (all 0) IPv6 address. This is fine as since this IP is not used anywhere.

Reviewed By: maxwindiff

Differential Revision: D65824443

fbshipit-source-id: d8e1a662a49626c9d5df2484bb0e8043d60588c0
  • Loading branch information
Shrikrishna (Shri) Khare authored and facebook-github-bot committed Nov 12, 2024
1 parent 47e6ff0 commit 5b478d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fboss/agent/hw/sai/api/SaiDefaultAttributeValues.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ struct SaiHostifUserDefinedTrapDefaultPriority {

struct SaiIpAddressDefault {
folly::IPAddress operator()() const {
return folly::IPAddress{};
return folly::IPAddressV6("::");
}
};

Expand Down

0 comments on commit 5b478d5

Please sign in to comment.