cleanup TServerEventHandler connectionNewRequest callback

Reviewed By: jmswen

Differential Revision: D22736635

fbshipit-source-id: 8c64c23a5e7e0838571aaddd0b9cb88cb5869f8e

thrift/lib/cpp/server/TServerEventHandler.h

@@ -72,22 +72,6 @@ class TServerEventHandler {
     (void)ctx;
   }
 
-  /**
-   * Called when a connection started processing a new request.
-   *
-   * @param connCtx A pointer to the connection context. The context will remain
-   *                valid until the corresponding connectionDestroyed() call.
-   * @param reqCtx  A pointer to folly::RequestContext specific to this request.
-   *                The context will remain valid until everything started by
-   *                this request stopped running.
-   */
-  virtual void connectionNewRequest(
-      TConnectionContext* connCtx,
-      folly::RequestContext* reqCtx) {
-    (void)connCtx;
-    (void)reqCtx;
-  }
-
   /**
    * Called when a client has finished request-handling to delete server
    * context.

thrift/lib/cpp2/server/Cpp2Connection.cpp

@@ -234,10 +234,7 @@ void Cpp2Connection::requestReceived(
   auto reqCtx = baseReqCtx
       ? folly::RequestContext::copyAsRoot(*baseReqCtx, rootid)
       : std::make_shared<folly::RequestContext>(rootid);
-  auto handler = worker_->getServer()->getEventHandlerUnsafe();
-  if (handler) {
-    handler->connectionNewRequest(&context_, reqCtx.get());
-  }
+
   folly::RequestContextScopeGuard rctx(reqCtx);
 
   auto server = worker_->getServer();

thrift/lib/cpp2/transport/rocket/server/ThriftRocketServerHandler.cpp

@@ -300,10 +300,6 @@ void ThriftRocketServerHandler::handleRequestCommon(
       ? folly::RequestContext::copyAsRoot(*baseReqCtx, rootid)
       : std::make_shared<folly::RequestContext>(rootid);
 
-  if (auto* handler = worker_->getServer()->getEventHandlerUnsafe()) {
-    handler->connectionNewRequest(&connContext_, reqCtx.get());
-  }
-
   folly::RequestContextScopeGuard rctx(reqCtx);
 
   auto requestPayloadTry = unpack<RequestPayload>(std::move(payload));