Use FOLLY_DEPRECATED rather than __attribute__((__deprecated__)) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because MSVC doesn't support `__attribute__` modifiers.
juchem
added a commit
that referenced
this pull request
Jan 21, 2016
Use FOLLY_DEPRECATED rather than __attribute__((__deprecated__))
ghost
pushed a commit
that referenced
this pull request
Feb 2, 2016
Summary: Because MSVC doesn't support `__attribute__` modifiers. Closes #113 Reviewed By: juchem Differential Revision: D2853366 Pulled By: Orvid fb-gh-sync-id: dcdb841b1c5eee6461796d81ddf3b204a2ba4450
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: facebook/sapling#113 GitHub Actions was failing at apt-get stage, error message suggested adding an apt-get update as remedy. Added in this diff and it indeed works. The actions build fails later on missing mio::net module when building mysql async, but that's unrelated to this change. Reviewed By: farnz Differential Revision: D34368662 fbshipit-source-id: f0a00da3ee740ae4443a328616e792ea615c922c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because MSVC doesn't support
__attribute__modifiers.