Flipper + Gradle 7 #2221
Comments
|
Same problem here |
|
Same problem here man :( |
|
Probably won't have the bandwidth to look into this in the near future. If someone wants to take a look and work on a PR, I'd be happy to take a look. |
Summary: This should no longer be needed as our Maven Publishing now happens through another plugin. This is blocking the upgrade to Gradle 7 mentioned in #2221. It's also deprecated: https://github.com/dcendents/android-maven-gradle-plugin Test Plan: Manually built things, ran `uploadArchives -PdryRun=true`. No issues.
Summary: This should no longer be needed as our Maven Publishing now happens through another plugin. This is blocking the upgrade to Gradle 7 mentioned in #2221. It's also deprecated: https://github.com/dcendents/android-maven-gradle-plugin Pull Request resolved: #2277 Test Plan: Manually built things, ran `uploadArchives -PdryRun=true`. No issues. Reviewed By: mweststrate Differential Revision: D28286834 Pulled By: passy fbshipit-source-id: d6163e8ecf2e982cf67499861e2f387068015773
|
This issue seems not be solved. Using version 0.92.0 still produces this error with gradle: Build file '/node_modules/react-native-flipper/android/build.gradle' line: 30 A problem occurred evaluating project ':react-native-flipper'. See: |
|
Same problem with version 0.93.0... even if it is supposed to be fixed by this commit : 0df76e7 as mentionned above. 🤔 Maybe I did something wrong ? |
|
The error is still in 0.94.1. @passy: Are we doing something wrong or is the error still unfixed? |
|
Sorry, I think I missed the RN bit as part of the conversion. Will take a look in the next few days. |
Summary: (Hopefully) fixes #2221 Test Plan: `yarn android` in the sample app. Not entirely sure if there's a better way to test this.
|
There are still some issues with the RN integration which show up in CI. I won't be able to look into this in the near future so if someone else would like to take a stab at it, please feel free! It's worth noting that React Native itself isn't on Gradle 7 yet so I'm not sure if this is supported. |
- Bump Android SDK Build Tools versions to 4.2.1 - Bump Android Gradle AGP to 7.1.0-alpha04 - Fix No such property: ABI for class: org.gradle.api.tasks.OutputFile - Upgrade with Gradle Wrapper to 7.1.1 - Remove trailing semi's Fix failed exec task generatePackageList > argument type mismatch - Patch @react-native-community/cli-platform-android Fix react-native-flipper - Patch react-native-flipper (PR after) - Resolve: facebook/flipper#2221 Locally - Brew install gradle (for wrapper) - Brew remove old old adoptopenjdk8 - Brew install openjdk (16) - Brew install --cask adoptopenjdk (16)
- Resolve: facebook#2221 - Tested working example: https://github.com/leotm/react-native-template-typescript - Commit: leotm/react-native-template-new-architecture@2fd5737
|
Got the same couple issues as OP with Flipper 0.99, cheers @lucasapereira for raising 🍻 Uploaded more detailed logs here Got it working in a minimal template project in the end with Hermes Some deets on what needed to be done And PR here Screen below
|
- Android Gradle ver and iOS Cocoa pod - #75 - facebook/flipper#2221 - facebook/flipper#2619
🐛 Bug Report
Flipper is not working with Gradle 7
To Reproduce
distributionUrl=https://services.gradle.org/distributions/gradle-7.0-bin.zip
Environment
Flipper 0.85
1: Task failed with an exception.
Where:
Build file '/Users/lucas/pontoaponto/pap-passageiro-mobile/node_modules/react-native-flipper/android/build.gradle' line: 30
What went wrong:
A problem occurred evaluating project ':react-native-flipper'.
2: Task failed with an exception.
A problem occurred configuring project ':react-native-flipper'.
The text was updated successfully, but these errors were encountered: