Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IOS crash in Network Plugin due to incorrect processing of data U… #978

Closed
wants to merge 3 commits into from
Closed

Fix IOS crash in Network Plugin due to incorrect processing of data U… #978

wants to merge 3 commits into from

Commits on Apr 5, 2020

  1. Fix IOS crash in Network Plugin due to incorrect processing of data U… 

    …RLs (#974)

Summary:
Fix #974 by skipping response processing in FlipperKitNetworkPlugin.mm
if the response is not an instance of NSHTTPURLResponse, which data URLs are not. My assumption is that data URLs
are not the ones Flipper Network Plugin users are interested in, given the type of information being extracted in
the didObserveResponse method which are only present in NSHTTPURLReponse types.
    @mark-plukkido
    mark-plukkido committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    001f33d View commit details
    Browse the repository at this point in the history

  2. Fix unchecked cast to NSHTTPURLResponse in SKResponseInfo.m as well

    @mark-plukkido
    mark-plukkido committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    3fdd786 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Strip the body of the response when it derives from a data URI

    @mark-plukkido
    mark-plukkido authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    13d98e7 View commit details
    Browse the repository at this point in the history