Add a couple of throws for bad states

facebook · Jan 24, 2024 · f4bee14 · f4bee14
1 parent 914a4f1
commit f4bee14
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/folly/experimental/io/EpollBackend.cpp b/folly/experimental/io/EpollBackend.cpp
@@ -94,7 +94,9 @@ void SignalRegistry::notify(int sig) {
   int fd = notifyFd_.load();
   if (fd >= 0) {
     uint8_t sigNum = static_cast<uint8_t>(sig);
-    ::write(fd, &sigNum, 1);
+    if (::write(fd, &sigNum, 1) != 1) {
+      throw std::runtime_error("Failed to write all the byes.");
+    }
   }
 }
 

diff --git a/folly/experimental/settings/Types.cpp b/folly/experimental/settings/Types.cpp
@@ -16,6 +16,8 @@
 
 #include <folly/experimental/settings/Types.h>
 
+#include <string_view>
+
 namespace folly {
 namespace settings {
 
@@ -27,6 +29,8 @@ std::string_view toString(SetErrorCode code) {
       return "rejected";
     case SetErrorCode::FrozenImmutable:
       return "frozen immutable";
+    default:
+      throw std::invalid_argument("Code '" + std::to_string(static_cast<int>(code)) + "' had no string representation!");
   }
 }