symbolizer: cache each DWARF DIE's nextOffset and nextSiblingOffset #2111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids exponential growth in runtime when parsing deeply nested debug info. The scenario that would otherwise lead to exponential growth involves
forEachChild()
with an argument lambda that itself recurses into children. At each layer of depth,forEachChild()
iterates over all indirect children (to skip them) and so does the argument lambda (to process the top-level ones and recurse on their children). So each top-level DIE is visited twice, each second-level is visited four times, each third-level one is visited eight times, and so on.