Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with nvcc #2148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Feb 21, 2024

These fixes are required to compile folly as part of velox with the NVIDIA toolchain. I expect these are mostly compiler-related bugs.

@facebook-github-bot
Copy link
Contributor

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Orvid
Copy link
Contributor

Orvid commented Feb 21, 2024

Which versions of NVCC has this been tested with?

@luhenry
Copy link
Contributor Author

luhenry commented Feb 22, 2024

@Orvid this has been tested with CUDA V12.2.140. This is the patchset that I've needed to be able to compile Velox on nvidia: rivosinc/velox@05a892a#diff-cd873badec87da0106ffc48d83c62dc7607bbd219ee8f31487a695aa304c6e46

cc @pedroerp

@facebook-github-bot
Copy link
Contributor

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants