Mac os compilation changes #27
Conversation
ghost
assigned 
|
+1 |
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
|
Sorry for taking so long to get to this. I've been working my way through folly's open pulls over the past few weeks, dealing with the languishing requests. I am unable to review this request because the CLA has not been signed. If you sign the CLA, then I can look at the patch. I can, however, comment on the general state of our multi-platform approach. We're working on getting folly continuously tested on different platforms; in the interim, we are accepting minor patches, but large/architectural changes are prone to breaking and so are much harder to accept. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! Also, looks like it needs a rebase. |
|
I haven't looked at this patch in a while. I'll rebase and resubmit a new patch when I can. This can be closed in the meantime. |
Summary: Pull Request resolved: facebook/sapling#27 Pull Request resolved: facebookexperimental/rust-shed#9 Original diffs: D22417488 (43d80f1), D22528869 (3930a6e) Reviewed By: markbt Differential Revision: D22571972 fbshipit-source-id: c6f013565680a757b642dd79e647207fce3351ec
Summary: Pull Request resolved: facebook/sapling#27 Pull Request resolved: facebookexperimental/rust-shed#9 Original diffs: D22417488 (facebook@43d80f1), D22528869 (facebook@3930a6e) Reviewed By: markbt Differential Revision: D22571972 fbshipit-source-id: c6f013565680a757b642dd79e647207fce3351ec
Summary: X-link: facebook/fb303#27 When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/). This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment. Reviewed By: mackorone Differential Revision: D34696330 fbshipit-source-id: 42aa0d8878c553b860eab3077313983028a315a8
Hi,
I have made some changes to enable folly's compilation on mac osx. I tested this with GCC 4.7.2 on mountain lion. I have made a note of the list of changes on the README.osx along with one additional dependency for osx. Please let me know if you have questions.
Thanks
Badhri