Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Fix master branch broken for Clang #779

Closed
wants to merge 1 commit into from
Closed

[Build] Fix master branch broken for Clang #779

wants to merge 1 commit into from

Commits on Feb 22, 2018

  1. [Build] Fix master branch broken for Clang 

    Summary:
Clang does not support the warning option "-Wclobbered", so we cannot
do a pragma push and pop for this warning. So, we push and pop this
particular warning for GCC only.

As it stands currently, Clang accepts `#pragma GCC` directives. If this
sort of thing comes up more in the future, it may make sense for Folly
to define a macro for easily disabling warnings for either just GCC or
just Clang.
    @JoeLoser
    JoeLoser committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    b918483 View commit details
    Browse the repository at this point in the history