Reserve the vector to save reallocation cost. #998
Conversation
Even though this is a test, we are still reallocating a vector (resizing until re-sized/reallocated to 32), which in theory calls for allocation 5 times. But we can save this by just reserving the vector pre-hand (we know the size).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@facebook-github-bot Done :) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@facebook-github-bot Is there anything else you need? |
There was a problem hiding this comment.
@yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@yfeldblum does imported mean that this was merged? |
|
It means that a copy of this PR exists in the internal code review tool. |
|
I see @yfeldblum, so then you will close this one once the internal one merges? |
|
Yes, the PR will be automatically closed. |
|
Thanks for the merge! @facebook-github-bot |
Summary: Even though this is a test, we are still reallocating a vector (resizing until re-sized/reallocated to 32), which in theory calls for allocation 5 times. But we can save this by just reserving the vector pre-hand (we know the size). Pull Request resolved: facebook#998 Reviewed By: magedm Differential Revision: D13834292 Pulled By: yfeldblum fbshipit-source-id: 6b0d16ef0200184d10ba292a0b1d8d3afdadf56d
…Hub Actions (#998) Summary: Pull Request resolved: facebook/watchman#998 A detailed description of this change is included in the new comment. Reviewed By: fanzeyi Differential Revision: D34124030 fbshipit-source-id: f37c458bae135357e16b256e09f0d6eb8f1f996d
Even though this is a test, we are still reallocating a vector (resizing until re-sized/reallocated to 32), which in theory calls for allocation 5 times. But we can save this by just reserving the vector pre-hand (we know the size).