Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to [email protected] #11142

Merged
merged 10 commits into from
Feb 9, 2022
Merged

chore: update to [email protected] #11142

merged 10 commits into from
Feb 9, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 2, 2021

Summary

Why not 😀

Test plan

Green CI

@SimenB
Copy link
Member Author

SimenB commented Mar 2, 2021

Parsing error reported to Babel: babel/babel#12957

@SimenB
Copy link
Member Author

SimenB commented Mar 15, 2021

@orta is this mess expected from TS 4.2? I don't see import type t = require('t'); in the changelog, babel parser threw an error until today's release, I just filed a bug with WebStorm since they error with a syntax error as well. And now our type tests fail with Only ECMAScript imports may use 'import type'.. Which vibes horribly with

packages/jest-globals/src/index.ts:10:1 - error TS1371: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' is set to 'error'.

10 import importedExpect = require('expect');

If this was an expected breaking change as part of the 4.2 release it probably warrants a mention in the blog post at least

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #11142 (277026b) into main (4af559a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11142   +/-   ##
=======================================
  Coverage   67.22%   67.23%           
=======================================
  Files         330      330           
  Lines       17347    17347           
  Branches     5068     5068           
=======================================
+ Hits        11662    11663    +1     
+ Misses       5653     5652    -1     
  Partials       32       32           
Impacted Files Coverage Δ
packages/expect/src/toThrowMatchers.ts 93.67% <ø> (ø)
packages/jest-circus/src/run.ts 6.02% <ø> (ø)
packages/jest-circus/src/types.ts 100.00% <ø> (ø)
packages/jest-circus/src/utils.ts 11.79% <ø> (ø)
...ges/jest-config/src/readConfigFileAndSetRootDir.ts 2.70% <ø> (ø)
packages/jest-core/src/TestScheduler.ts 81.08% <ø> (ø)
packages/jest-core/src/runGlobalHook.ts 32.00% <ø> (ø)
packages/jest-fake-timers/src/legacyFakeTimers.ts 94.97% <ø> (ø)
packages/jest-globals/src/index.ts 100.00% <ø> (ø)
packages/jest-jasmine2/src/PCancelable.ts 35.48% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af559a...277026b. Read the comment docs.

@SimenB SimenB changed the title chore: update to [email protected] chore: update to [email protected] Oct 11, 2021
@SimenB
Copy link
Member Author

SimenB commented Oct 11, 2021

Now blocked by MLH-Fellowship/tsd#14

@SimenB
Copy link
Member Author

SimenB commented Feb 5, 2022

Blocked by #12220 (and #12219 for 4.5)

@SimenB SimenB marked this pull request as ready for review February 9, 2022 11:33
@SimenB SimenB changed the title chore: update to [email protected] chore: update to [email protected] Feb 9, 2022
@SimenB SimenB merged commit e98d044 into jestjs:main Feb 9, 2022
@SimenB SimenB deleted the ts-4.2.2 branch February 9, 2022 11:49
@mrazauskas
Copy link
Contributor

Yes!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants