chore: migrate to yarn berry #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
changed the title
tsd instead of mhl-tsdtsd instead of mlh-tsd
|
A patch only applies locally, it's not applied to for consumers. So we'd need to use your fork instead of We can update to yarn v2 separately, tho 🙂 |
|
Meh.. I felt there is some trick. Ok. I will refactor this to update Yarn. Let’s wait for |
mrazauskas
changed the title
tsd instead of mlh-tsd
SimenB
reviewed
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if yarn-patched
tsdwould be used instead ofmlh-tsd? Does it cause any trouble?The patch is based on the PR I have send to
tsd. The change is minimal and it is covered by a test (I mean, my branch includes passing test). This library also has e2e tests. The result is predictable. Or?This solution would allow to uncomment type tests in
jestrepo. And would unblock jestjs/jest#11142 too.@SimenB What you think?