Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve & document NPM package addition process #5869

Open
StyleT opened this issue Apr 10, 2024 · 4 comments
Open

Improve & document NPM package addition process #5869

StyleT opened this issue Apr 10, 2024 · 4 comments
Assignees
Labels
devx enhancement Improvement over existing feature infra-bug An issue that doesn't affect external users

Comments

@StyleT
Copy link
Contributor

StyleT commented Apr 10, 2024

At this moment addition of the new NPM package to Lexical monorepo requires repetitive updates to ~10 different files. On top of that Meta specific WWW build requires separate changes done to internal codebase in order to keep it running.

Example:
In #5861 we reverted #5830 that added @lexical/devtools-core package. Later it was re-added in #5864 with fixes done to the build system.

Scope:

  • Document steps necessary to add new NPM package to Lexical monorepo. Specifically:
    • PR description format to highlight new package addition
    • Changes to the shared files necessary
    • Merge procedure
  • Reduce number of changes needed to add new package
@StyleT StyleT added enhancement Improvement over existing feature infra-bug An issue that doesn't affect external users devx labels Apr 10, 2024
@StyleT StyleT self-assigned this Apr 10, 2024
@etrepum
Copy link
Collaborator

etrepum commented Apr 10, 2024

I'd be happy to work on this if you want to delegate, I have been touching the build and documentation a lot lately. See also #5858 and #5850

@etrepum
Copy link
Collaborator

etrepum commented Apr 10, 2024

I think if we pull out the code I have in those two PRs into shared modules we can use that across the board to handle basically all of the hard-coded mess across the build scripts

@StyleT
Copy link
Contributor Author

StyleT commented Apr 10, 2024

@etrepum feel free to jump on it! I can later add Meta specific WWW build steps

@etrepum
Copy link
Collaborator

etrepum commented Apr 10, 2024

@StyleT will do, if you can get those PRs approved/merged (or at least one of them?) it would make it a little easier for me since AFAIK you can only stack on top of at most one of them as a base branch with the github workflow

etrepum added a commit to etrepum/lexical that referenced this issue Apr 17, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 20, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 20, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 21, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 22, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 22, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 22, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 22, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 22, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
…s and build integration tests

Extracted from facebook#5876 to hopefully land it in smaller chunks.
Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
etrepum added a commit to etrepum/lexical that referenced this issue Apr 23, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 24, 2024
etrepum added a commit to etrepum/lexical that referenced this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx enhancement Improvement over existing feature infra-bug An issue that doesn't affect external users
Projects
None yet
Development

No branches or pull requests

2 participants