[Lexical] Add flow for eslint

[Sahejkm]

add flow for eslint

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 17, 2024 2:24pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 17, 2024 2:24pm

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/lexical/dist/Lexical.js	23.91 KB (0%)	479 ms (0%)	482 ms (+50.92% 🔺)	960 ms
packages/lexical-rich-text/dist/LexicalRichText.js	34.6 KB (0%)	693 ms (0%)	790 ms (-2.34% 🔽)	1.5 s
packages/lexical-plain-text/dist/LexicalPlainText.js	34.51 KB (0%)	691 ms (0%)	841 ms (-2.95% 🔽)	1.6 s

[etrepum]

LGTM, this is the fix for the script that generated this incorrectly if you want to add that as well (diff updated with correct regex)

diff --git a/scripts/update-flowconfig.js b/scripts/update-flowconfig.js
index be35f36d..81c82d4c 100644
--- a/scripts/update-flowconfig.js
+++ b/scripts/update-flowconfig.js
@@ -23,7 +23,7 @@ const BLOCK_REGEX =
 
 function flowTemplate(wwwName) {
   return (
-    headerTemplate.replace(/^( \*\/)$/m, '* @flow strict\n$1') +
+    headerTemplate.replace(/^( \*\/)$/m, ' * @flow strict\n$1') +
     `
 /**
  * ${wwwName}
@@ -59,22 +59,7 @@ function updateFlowconfig(flowconfigPath = './.flowconfig') {
     const resolveRelative = (...subPaths) =>
       '<PROJECT_ROOT>/' +
       path.relative(configDir, pkg.resolve(...subPaths)).replace(/^(?!\.)/, '');
-    if (pkg.isPrivate()) {
-      if (pkg.getDirectoryName() !== 'shared') {
-        continue;
-      }
-      if (process.env.TODO_DOES_WWW_NEED_SHARED_FILES === '1') {
-        // Do these even work? These .js files aren't on disk and `npm run flow`
-        // passes without them. Code is left in for demonstration purposes if
-        // this is needed for www.
-        for (const {name, sourceFileName} of pkg.getPrivateModuleEntries()) {
-          emit(
-            name,
-            resolveRelative('src', sourceFileName.replace(/\.tsx?$/, '.js')),
-          );
-        }
-      }
-    } else {
+    if (!pkg.isPrivate()) {
       for (const name of pkg.getExportedNpmModuleNames()) {
         const wwwName = npmToWwwName(name);
         const flowFile = `${wwwName}.js.flow`;
@@ -85,6 +70,7 @@ function updateFlowconfig(flowconfigPath = './.flowconfig') {
           console.log(
             `Creating boilerplate ${resolvedFlowFile.replace(/^[^/]+\//, '')}`,
           );
+          fs.mkdirsSync(path.dirname(flowFilePath));
           fs.writeFileSync(flowFilePath, flowTemplate(wwwName));
         }
       }

[etrepum]

er, hold off on that diff, I just tested it again and the regex is wrong 🤦 will post the correct tested diff shortly

[etrepum]

Just updated the diff above with the corrected regex, sorry about that! Early here :)

[Sahejkm]

thanks Bob for the update on the script :)