Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom ScrollStateDetector implementation #757

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Jan 21, 2021

  1. Allow users to provide a custom ScrollStateDetector

    This change breaks the existing ScrollStateDetector implementation
    into two. It extracts an interface that users can potentially
    implement to provide their own ScrollStateDetector. It also creates
    an additional DefaultScrollStateDetector class that now contains the
    default ScrollStateDetector implementation.
    chggr committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    21120d3 View commit details
    Browse the repository at this point in the history
  2. Adds onInterceptTouchEvent support to ScrollStateDetector

    This change adds onInterceptTouchEvent support to ScrollStateDetector
    and the relevant hooks in LithoScrollView and HorizontalScrollSpec.
    The implementation in the DefaultScrollStateDetector will be a no-op,
    because in that class all detection is done through onTouchEvent.
    Finally it also adds documentation in the ScrollStateDetector
    interface.
    chggr committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a8bd6ec View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. ScrollStateDetector should be @nullable

    This change addds @nullable for ScrollStateDetector in both the
    HorizontalScrollSpec and VerticalScrollSpec. It also changes the
    method names in DefaultScrollStateDetectorTest to conform to the
    Litho standard.
    chggr committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    c87b0b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    5c01a0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7392d96 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Configuration menu
    Copy the full SHA
    16b3a4e View commit details
    Browse the repository at this point in the history